Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "maven-publish.yml" #539

Closed
Marcono1234 opened this issue Jun 3, 2020 · 2 comments
Closed

Improve "maven-publish.yml" #539

Marcono1234 opened this issue Jun 3, 2020 · 2 comments

Comments

@Marcono1234
Copy link
Contributor

Marcono1234 commented Jun 3, 2020

Hello,
maven-publish.yml could probably be improved:

  1. Improve command line parameters, see also Improve maven.yml #538
  2. Link to https://github.com/actions/setup-java#apache-maven-with-a-settings-path should be placed directly above settings-path: because it is irrelevant for everything else
  3. Add link to https://github.com/actions/setup-java#publishing-using-apache-maven in header comment (or to GitHub Help: Publishing Java packages with Maven)
  4. Remove redundant step name: Build with Maven, deploy already includes package so it essentially runs package (and all phases before it) twice
    Edit: deploy would skip compiling (since package already did this), but would run tests again.
  5. Add --batch-mode to deploy to prevent output which is intended for interactive console
  6. Write out -s as --settings to make it easier to understand for users who are not familiar with all command line options
  7. Change name "Publish to GitHub Packages Apache Maven" to "Publish to GitHub Packages with Maven" to be consistent with other message
  8. It might be possible to run deploy with -Dmaven.install.skip=true to skip installing the package to the local repository since that could cause issues when a cache step is used and a large number of the packages of the project accumulate (only happens if the version of the package changes frequently). Though would be good if someone with more Maven deployment experience could confirm this.

Let me know if you want me to write a pull request.

See also actions/setup-java#75

@github-actions
Copy link

This issue has become stale and will be closed automatically within a period of time. Sorry about that.

@andymckay
Copy link
Contributor

I'm not a maven user, but a pull request for these changes would be most welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants