You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Remove redundant step name: Build with Maven, deploy already includes package so it essentially runs package (and all phases before it) twice
Edit: deploy would skip compiling (since package already did this), but would run tests again.
Add --batch-mode to deploy to prevent output which is intended for interactive console
Write out -s as --settings to make it easier to understand for users who are not familiar with all command line options
Change name "Publish to GitHub Packages Apache Maven" to "Publish to GitHub Packages with Maven" to be consistent with other message
It might be possible to run deploy with -Dmaven.install.skip=true to skip installing the package to the local repository since that could cause issues when a cache step is used and a large number of the packages of the project accumulate (only happens if the version of the package changes frequently). Though would be good if someone with more Maven deployment experience could confirm this.
Let me know if you want me to write a pull request.
Hello,
maven-publish.yml
could probably be improved:settings-path:
because it is irrelevant for everything elsename: Build with Maven
,deploy
already includespackage
so it essentially runspackage
(and all phases before it) twiceEdit:
deploy
would skip compiling (sincepackage
already did this), but would run tests again.--batch-mode
todeploy
to prevent output which is intended for interactive console-s
as--settings
to make it easier to understand for users who are not familiar with all command line optionsdeploy
with-Dmaven.install.skip=true
to skip installing the package to the local repository since that could cause issues when a cache step is used and a large number of the packages of the project accumulate (only happens if the version of the package changes frequently). Though would be good if someone with more Maven deployment experience could confirm this.Let me know if you want me to write a pull request.
See also actions/setup-java#75
The text was updated successfully, but these errors were encountered: