Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no_proxy matching agains parts of the host name is not supported #1172

Closed
gendergap opened this issue Sep 5, 2022 · 0 comments · Fixed by #1223
Closed

no_proxy matching agains parts of the host name is not supported #1172

gendergap opened this issue Sep 5, 2022 · 0 comments · Fixed by #1223

Comments

@gendergap
Copy link

It is quite common to define the no_proxy environment variable like this:

NO_PROXY=.part.of.some.domain.com,some-other-host.domain.com

In practice, this matches all contained hosts for many HTTP clients. But for action runners, it does not.
Consider a GitHub host like github.part.of.some.domain.com. I would expect this host to be excluded from the HTTP proxy, but the Actions runner only recognizes this if I put the variable like this:

NO_PROXY=github.part.of.some.domain.com,.part.of.some.domain.com,some-other-host.domain.com

The relevant code is https://github.com/actions/toolkit/blob/main/packages/http-client/src/proxy.ts#L50

Perhaps the no_proxy matching could be broadened a bit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant