Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Octokit deprecation warning #333

Closed
JasonEtco opened this issue Feb 4, 2020 · 1 comment
Closed

Octokit deprecation warning #333

JasonEtco opened this issue Feb 4, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@JasonEtco
Copy link
Collaborator

Describe the bug

Hey folks 馃憢 I'm seeing a deprecation warning for @octokit/rest.js when importing @actions/github. This looks to be the offending code (h/t @joshmgross):

import Octokit from '@octokit/rest'

And the warning:

[@octokit/rest] `const Octokit = require("@octokit/rest")` is deprecated. Use `const { Octokit } = require("@octokit/rest")` instead

Looks like perfectly valid warning! cc-ing @gr2m for 馃憖

Additional context

@actions/github: 2.1.0
@octokit/rest: 16.43.1

@joshmgross
Copy link
Member

Should be fixed now with #332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants