Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no documentation on how to suppress warning annotations that occur in files not modified in a given pull request #559

Open
JasonGross opened this issue Aug 17, 2020 · 1 comment
Labels
enhancement New feature or request external

Comments

@JasonGross
Copy link

The document at https://github.com/actions/toolkit/blob/master/docs/problem-matchers.md makes no mention of how to suppress warnings that occur in files not modified in a given PR. If this feature is not yet available, it should be made available (either on a per-matcher or, perhaps, a per-repository basis) and there should be documentation about how to accomplish this.

@electronjoe
Copy link
Contributor

Agree, I have a PR up for the documentation to make Problem Matcher docs more clear on the annotation limits today (which combine poorly with lack of filtering, as you call out). I have 600 annotations in our project - from GCC warnings. I ultimately added shell processing of the tool warnings to pre-filter by files modified (e.g. using get-changed-files@v2 - which itself has some issues with workflows that involve forked-branch-PR-to-upstream-master). If a tool only allows 10 annotations per step, some form of filtering support is pretty important (or everybody will roll their own).

@thboop thboop added external enhancement New feature or request and removed bug Something isn't working labels Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request external
Projects
None yet
Development

No branches or pull requests

3 participants