Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "file(s)" with "file" or "files" #159

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Dec 29, 2020

Instead of:

With the provided path, there will be 1 file(s) uploaded

Show either:

With the provided path, there will be 1 file uploaded

Or:

With the provided path, there will be 2 files uploaded

@hugovk hugovk requested a review from a team as a code owner December 29, 2020 09:09
Copy link
Collaborator

@konradpabjan konradpabjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Making changes to any files under src/* also requires dist/index.js to be rebuilt using npm run release. I'll take care of that though since I'm working on a new release in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants