Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ommitting the path #16

Closed
LeonarddeR opened this issue Sep 20, 2019 · 1 comment
Closed

Allow ommitting the path #16

LeonarddeR opened this issue Sep 20, 2019 · 1 comment
Labels
wontfix This will not be worked on

Comments

@LeonarddeR
Copy link

It is now required to provide a path for every artifact you upload. I have a repository where the artifacts are ending up in the root of the git repository (it is a fairly small project). I would expect the default path to be the git repository and a possible override of the path being relative to it, but this might not be true, it is not documented that clearly. Anyway, if the artifacts to upload are in a default path, specifying the path is redundant.

@konradpabjan konradpabjan added the wontfix This will not be worked on label Dec 23, 2019
@konradpabjan
Copy link
Collaborator

Path omission is something we are not going to add.

When you use actions/checkout to checkout your git repository, everything gets put into $GITHUB_WORKSPACE. If the default upload path was set to the same thing, users would be uploading effectively what they just checked out and we don't want to encourage the practice (most likely with some new files etc., but the majority of what they upload would be equal to what they checked out). Most repositories are small, but this behavior could be very problematic for users who are checking out big repositories and hit quotas with the artifacts they produce.

Artifacts are meant to be things other than source code such as test output or build output. When you run tests or a build, you can (most of the time) specify where you want that output to go and later use that as the PATH input when uploading an artifact. Before upload, you can also separately move the files that end up in the root git directory to some other directory.

Overall, we want users to be explicit with what they upload and having the default path set to the git repository could cause of a lot of users to upload source code that they just checked out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants