Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update miniconda on Windows from 4.6.14 to 4.8.3 #1580

Closed
2 of 6 tasks
weiji14 opened this issue Sep 13, 2020 · 8 comments
Closed
2 of 6 tasks

Update miniconda on Windows from 4.6.14 to 4.8.3 #1580

weiji14 opened this issue Sep 13, 2020 · 8 comments

Comments

@weiji14
Copy link
Contributor

weiji14 commented Sep 13, 2020

Tool information

Area for Triage:
Packages

Question, Bug, or Feature?:
Feature

Virtual environments affected

  • macOS 10.15
  • Ubuntu 16.04 LTS
  • Ubuntu 18.04 LTS
  • Ubuntu 20.04 LTS
  • Windows Server 2016 R2
  • Windows Server 2019

Can this tool be installed during the build?

Tool installation time in runtime

Are you willing to submit a PR?
Yes, if someone can guide me a bit on where to start 😄

These lines seem to suggest that Miniconda was pinned to 4.6.14 (released April 2019) for some reason, is that reason still valid?

https://github.com/actions/virtual-environments/blob/b47ba413c9bd9411407b8a5cf18e2c14ea8bda78/images/win/scripts/Installers/Install-Miniconda.ps1#L10-L15

xref conda-incubator/setup-miniconda#58 (comment)

@maxim-lobanov
Copy link
Contributor

@weiji14 , no any reason to hardcode specific version. I think it may be upgraded to 4.8.3 or even latest (https://repo.anaconda.com/miniconda/Miniconda3-latest-Windows-x86_64.exe) to simplify future maintenance.
Do you want to submit PR?

@weiji14
Copy link
Contributor Author

weiji14 commented Sep 14, 2020

Sure, I'll give it a go 😄

@maxim-lobanov
Copy link
Contributor

Thank you for the PR,
we would like to get more context why 4.6.14 was hardcoded previously and I have pinged a few people. Hope it will take little time

@maxim-lobanov
Copy link
Contributor

Hello @weiji14 , Sorry for delay.
Changes were merged and new image will be deployed in 1-2 weeks

@maxim-lobanov maxim-lobanov added the awaiting-deployment Code complete; awaiting deployment and/or deployment in progress label Oct 13, 2020
@weiji14
Copy link
Contributor Author

weiji14 commented Oct 13, 2020

Awesome! Thanks for keeping on top of this, looking forward to the deployment!

@weiji14
Copy link
Contributor Author

weiji14 commented Oct 27, 2020

Changes appear to deployed, close this?

@maxim-lobanov
Copy link
Contributor

Changes are still deploying (Some machines are already updated, some not). It should be finished today. After that we will close issue.
Everything works as expected for you?

@miketimofeev
Copy link
Contributor

@weiji14 the images were deployed!
Miniconda version is 4.8.3
https://github.com/actions/virtual-environments/blob/main/images/win/Windows2019-Readme.md#database-tools
I'm going to close the issue, thank you for your contribution!
Please feel free to contact us if you have any concerns.

@miketimofeev miketimofeev removed the awaiting-deployment Code complete; awaiting deployment and/or deployment in progress label Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants