Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Microsoft.VisualStudio.Component.VC.Redist.MSM for Visual Studio 2019 in Windows Server 2019 #195

Closed
1 of 5 tasks
allexzander opened this issue Dec 20, 2019 · 6 comments
Labels

Comments

@allexzander
Copy link

Tool information

Area for Triage: C/C++
Question, Bug, or Feature?: Feature

Virtual environments affected

  • macOS 10.15
  • Ubuntu 16.04 LTS
  • Ubuntu 18.04 LTS
  • Windows Server 2016 R2
  • Windows Server 2019

Can this tool be installed during the build?
Currently, as a workaround, we install this component via the PowerShell, using the following command:
Start-Process "C:\Program Files (x86)\Microsoft Visual Studio\Installer\vs_installer.exe" -ArgumentList 'modify --installPath "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise" --quiet --add Microsoft.VisualStudio.Component.VC.Redist.MSM' -Wait -PassThru

It takes 10-15 minutes to install, that's why we would like to have it installed in advance to reduce the duration of every build.

Are you willing to submit a PR?
Kindly, add this component name Microsoft.VisualStudio.Component.VC.Redist.MSM into the VS 2019 installation script here https://github.com/actions/virtual-environments/blob/master/images/win/scripts/Installers/Windows2019/Install-VS2019.ps1 into $WorkLoads list. This should do it.

@kaylangan kaylangan added Area: C/C++ enhancement New feature or request labels Dec 20, 2019
@github-actions
Copy link
Contributor

This issue has not had any activity for 45 days and will be closed in 45 days if there continues to be no activity.

@alepauly
Copy link
Contributor

@allexzander sorry for the delay in looking at this. Is it still an issue for you?

@allexzander
Copy link
Author

@allexzander sorry for the delay in looking at this. Is it still an issue for you?

Hi @alepauly,

We are using a workaround by manually installing this component during the build process. It would be nice to have it added by default into a virtual OS image, so we would save the time spent for the installation for every build.

@alepauly
Copy link
Contributor

Hi @allexzander, we briefly looked into it and considering the size of the component and maintenance concerns, we won't be baking it into the image at this time.

@qminds
Copy link

qminds commented Jul 29, 2021

@alepauly And how about now? In fact, the merge modules is a crucial component in many CI/CD builds where an MSI package depends on this type of VC runtime redistribution.

@slonopotamus
Copy link

slonopotamus commented Mar 20, 2022

https://github.com/actions/virtual-environments/blob/main/images/win/Windows2019-Readme.md claims that windows-2019 image contains Microsoft.VisualStudio.Component.VC.Redist.MSM at least for the past two years.

Note that Microsoft.VisualStudio.Component.VC.Redist.MSM is missing from windows-2022 image, that is supposed to be fixed in #5143.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants