-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zsh shell #264
Comments
Hello, @phil-blain As for now you can follow this approach: You can set the shell value to a template string using Example output:
|
This issue has not had any activity in 30 days, if you still require assistance please remove the |
Closing the issue since solution was provided above. Feel free to reopen if needs |
Since zsh is the default shell on Mac OS, it's surprising that it's not fully supported in Actions. |
@michaeltryby , bash and zsh shell are not equal. And switching to zsh can affect a lot of customers and break existing scripts |
@maxim-lobanov Actually its a little known fact that support for bash on Mac OS is not all that good. The default version of bash is quite old and scripts written for newer bash on Linux frequently don't run. The best solution would be to support both. |
@maxim-lobanov i really don't understand why this is closed. Nobody's asking to change the default, but zsh should still be a first-class supported option. |
Preinstalling zsh should be done on all platforms because it is a very common shell and many repositories do have shell support testing code. While is unlikely that someone would want to run jobs with zsh shell, the is a real chance they would have few tests around what happens with zsh (completions being one of them). Also zsh is small, so it should not concern increasing images too much. |
Why this one is closed? The shell is still missing on ubuntu-latest, for example too. |
@ki11roy installing zsh takes about 20 seconds in runtime so it shouldn't be the issue. |
@miketimofeev the time isn’t the issue; it’s knowing which install command to use, and having to conditionally run it when testing on a matrix of shells. |
Example use case for zsh on ubuntu-latest (substitution)
|
Can this issue please be reopened? There should be better supprt for |
@maxim-lobanov It's because from Catalina, default shell on Mac is This is not a high priority, but should be reopened. |
@sensuikan1973 , If you request adding zsh to Ubuntu images, feel free to log a separate feature request for Ubuntu OS. |
Turns out GitHub Actions doesn't have zsh installed actions/runner-images#264
Can we please re-open this issue? This is still relevant in 2023. |
Can we please re-open this issue? This is still relevant in 2024. |
Tool information
/bin/zsh
Area for Triage:
Scripting and command line
Question, Bug, or Feature?:
Feature
Virtual environments affected
Can this tool be installed during the build?
It's already installed, so jobs can do
zsh -c 'whatever'
or use a custom shell command but it would be easier to be able to write:Are you willing to submit a PR?
How would I do that ?....
The text was updated successfully, but these errors were encountered: