Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ubuntu, windows] GOROOT environment variable will be removed on March, 1 #2683

Closed
5 of 9 tasks
AlenaSviridenko opened this issue Feb 11, 2021 · 1 comment
Closed
5 of 9 tasks

Comments

@AlenaSviridenko
Copy link
Contributor

AlenaSviridenko commented Feb 11, 2021

Breaking changes
Predefined GOROOT environment variable will be removed on March, 1 from all Ubuntu and Windows images

Target date
Images deployment will start on March, 1 and will take 3-4 days.

The motivation for the changes

The GOROOT environment variable is mostly deprecated, and no setup requires it. The problem with hardcoding a GOROOT is that if any other go tool is in use (for example, because one compiled Go tip), the environment variable will override its autodetected GOROOT.

Please, see more details in #2655

Possible impact
If your workflow directly use GOROOT — your build will be broken.

Virtual environments affected

  • Ubuntu 16.04
  • Ubuntu 18.04
  • Ubuntu 20.04
  • macOS 10.13
  • macOS 10.14
  • macOS 10.15
  • macOS 11.0
  • Windows Server 2016 R2
  • Windows Server 2019

Mitigation ways
Set environment variable as
echo "GOROOT=$GOROOT_1_15_X64" >> $GITHUB_ENV

@AlenaSviridenko AlenaSviridenko changed the title [ubuntu] GOROOT environment variable will be removed on March, 1 [ubuntu, windows] GOROOT environment variable will be removed on March, 1 Feb 12, 2021
@miketimofeev miketimofeev added the awaiting-deployment Code complete; awaiting deployment and/or deployment in progress label Feb 24, 2021
@miketimofeev
Copy link
Contributor

We've finished image deployments!

@miketimofeev miketimofeev removed the awaiting-deployment Code complete; awaiting deployment and/or deployment in progress label Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants
@dsame @AlenaSviridenko @miketimofeev and others