Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ubuntu] Clang 9 will be removed on May, 17th and default will be set to Clang 11 #3235

Closed
1 of 9 tasks
AlenaSviridenko opened this issue Apr 22, 2021 · 5 comments
Closed
1 of 9 tasks

[ubuntu] Clang 9 will be removed on May, 17th and default will be set to Clang 11 #3235

AlenaSviridenko opened this issue Apr 22, 2021 · 5 comments
Assignees
@miketimofeev
Labels
Announcement Area: Clang awaiting-deployment Code complete; awaiting deployment and/or deployment in progress OS: Ubuntu

Comments

@AlenaSviridenko
Copy link
Contributor

AlenaSviridenko commented Apr 22, 2021 •
edited

Breaking changes
Clang 9 will be removed from Ubuntu 20.04 images in favor of Clang 12, also default will be set to Clang 11

Target date
Image deployment will start on May, 17th and will take 3-4 days

The motivation for the changes
Based on our guidelines we support 3 latest major versions of Clang, so in order to add a new one, we are removing Clang 9.

Possible impact
Projects that depend on Clang 9 or Clang 10 will be broken.

Virtual environments affected

  • Ubuntu 16.04
  • Ubuntu 18.04
  • Ubuntu 20.04
  • macOS 10.13
  • macOS 10.14
  • macOS 10.15
  • macOS 11.0
  • Windows Server 2016 R2
  • Windows Server 2019

Mitigation ways
The snippet below allows you installing Clang 9

sudo apt-get update
sudo apt-get install -y "clang-9" "lldb-9" "lld-9" "clang-format-9"

The following snippet will change default version to Clang 10 back:

update-alternatives --install /usr/bin/clang++ clang++ /usr/bin/clang++-10 100
update-alternatives --install /usr/bin/clang clang /usr/bin/clang-10 100
update-alternatives --install /usr/bin/clang-format clang-format /usr/bin/clang-format-10 100
@AlenaSviridenko AlenaSviridenko pinned this issue Apr 22, 2021
@AlenaSviridenko AlenaSviridenko mentioned this issue Apr 22, 2021
Merged
4 tasks
@EwoutH
Copy link
Contributor

EwoutH commented Apr 30, 2021

With this change, can we also move the default Clang version from 10 to 11?

@AlenaSviridenko
Copy link
Contributor Author

Good point, we can do that as well. I'll update the announcement, thanks!

@AlenaSviridenko AlenaSviridenko changed the title [ubuntu] Clang 9 will be removed on May, 17th [ubuntu] Clang 9 will be removed on May, 17th and default will be set to Clang 11 May 4, 2021
@miketimofeev miketimofeev self-assigned this May 13, 2021
@miketimofeev miketimofeev mentioned this issue May 13, 2021
Merged
4 tasks
@miketimofeev miketimofeev added the awaiting-deployment Code complete; awaiting deployment and/or deployment in progress label May 14, 2021
@KarlStraussberger KarlStraussberger mentioned this issue May 15, 2021
Merged
@claremacrae
Copy link

Possible impact
Projects that depend on Clang 9 or Clang 10 will be broken.

Why could projects that depend on Clang 10 be broken?

@claremacrae claremacrae mentioned this issue May 15, 2021
Closed
@miketimofeev
Copy link
Contributor

miketimofeev commented May 17, 2021 •
edited

@claremacrae looks like there is a mistake in the initial message. We're going to remove clang 9 only.
UPD: clang 10 builds can be broken since we change the default clang version from 10 to 11.

odygrd added a commit to odygrd/quill that referenced this issue May 17, 2021
@odygrd
Update linux.yml to install clang-9 (actions/runner-images#3235)
c5dfad5 
Add _force_flush change again
linusg added a commit to linusg/serenity that referenced this issue May 20, 2021
@linusg
CI: Bump update-alternatives priority to 100
00277f4 
This didn't seem to have worked in the past, the new value matches the
recomendation on the GitHub Actions clang-11 default announcement:

actions/runner-images#3235
linusg added a commit to SerenityOS/serenity that referenced this issue May 20, 2021
@linusg
CI: Bump update-alternatives priority to 100
90e5f60 
This didn't seem to have worked in the past, the new value matches the
recomendation on the GitHub Actions clang-11 default announcement:

actions/runner-images#3235
@locus313 locus313 mentioned this issue May 21, 2021
Merged
@zach2good zach2good mentioned this issue May 21, 2021
Merged
4 tasks
@miketimofeev
Copy link
Contributor

The deployment was completed.

@BrettDong BrettDong mentioned this issue May 21, 2021
Merged
2 tasks
Coderdreams pushed a commit to Coderdreams/serenity that referenced this issue May 22, 2021
@linusg @Coderdreams
CI: Bump update-alternatives priority to 100
5116b4c 
This didn't seem to have worked in the past, the new value matches the
recomendation on the GitHub Actions clang-11 default announcement:

actions/runner-images#3235
@AlenaSviridenko AlenaSviridenko unpinned this issue May 24, 2021
Hendiadyoin1 pushed a commit to Hendiadyoin1/serenity that referenced this issue May 24, 2021
@linusg @Hendiadyoin1
CI: Bump update-alternatives priority to 100
a757214 
This didn't seem to have worked in the past, the new value matches the
recomendation on the GitHub Actions clang-11 default announcement:

actions/runner-images#3235
@hewigovens hewigovens mentioned this issue May 25, 2021
Merged
5 tasks
@apcountryman apcountryman mentioned this issue May 28, 2021
Closed
apcountryman added a commit to apcountryman/picolibrary that referenced this issue May 28, 2021
@apcountryman
Explicitly set format CI job clang-format version
1e8cc26 
Resolves #461 (Explicitly set format CI job clang-format version).

The GitHub actions Ubuntu 20.04 image's default clang-format version has
changed from 10 to 11 (see
actions/runner-images#3235). The format
CI job now explicitly sets the clang-format version to 10 for
consistency with the development environment.
@apcountryman apcountryman mentioned this issue May 28, 2021
Merged
4 tasks
apcountryman added a commit to apcountryman/picolibrary that referenced this issue May 28, 2021
@apcountryman
Explicitly set format CI job clang-format version (#462)
ffdb197 
Resolves #461 (Explicitly set format CI job clang-format version).

The GitHub actions Ubuntu 20.04 image's default clang-format version has
changed from 10 to 11 (see
actions/runner-images#3235). The format
CI job now explicitly sets the clang-format version to 10 for
consistency with the development environment.
This was referenced May 28, 2021
Closed
Closed
Closed
Closed
@catthehacker catthehacker mentioned this issue Jun 12, 2021
Closed
7 tasks
TheOneRing added a commit to owncloud/client that referenced this issue Jun 16, 2021
@TheOneRing
Ci: Fix clang format
4c19f78 
actions/runner-images#3235
@TheOneRing TheOneRing mentioned this issue Jun 16, 2021
Closed
TheOneRing added a commit to owncloud/client that referenced this issue Jun 16, 2021
@TheOneRing
Ci: Fix clang format
c02301c 
actions/runner-images#3235
rishflab added a commit to rishflab/rust-secp256k1 that referenced this issue Jul 14, 2021
@rishflab
Use clang-12 on Ubuntu
2b1d008 
clang-9 has been deprecated.
actions/runner-images#3235
rishflab added a commit to rishflab/rust-secp256k1 that referenced this issue Jul 14, 2021
@rishflab
Use clang-12 on Ubuntu
3bf946a 
clang-9 has been deprecated.
actions/runner-images#3235
bonomat pushed a commit to bonomat/rust-secp256k1 that referenced this issue Jul 14, 2021
@rishflab @bonomat
Use clang-12 on Ubuntu
5ff693a 
clang-9 has been deprecated.
actions/runner-images#3235
bonomat pushed a commit to bonomat/rust-secp256k1 that referenced this issue Jul 14, 2021
@rishflab @bonomat
Use clang-12 on Ubuntu
db23fea 
clang-9 has been deprecated.
actions/runner-images#3235
@stefanofiorentino stefanofiorentino mentioned this issue Jan 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miketimofeev miketimofeev

Labels
Announcement Area: Clang awaiting-deployment Code complete; awaiting deployment and/or deployment in progress OS: Ubuntu
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@claremacrae @AlenaSviridenko @EwoutH @miketimofeev