Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail fast in image generation if not enough disk space for customers #752

Closed
5 tasks done
congyiwu opened this issue Apr 20, 2020 · 5 comments
Closed
5 tasks done
Assignees
Labels
Area: Image administration awaiting-deployment Code complete; awaiting deployment and/or deployment in progress OS: Ubuntu OS: Windows

Comments

@congyiwu
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is, and why you consider it to be a bug.

If we promise X GB of free disk space for customers, we should check that there is enough space at the end of image generation, and fail fast if there isn't.

Area for Triage:

There wasn't an area for general stuff

Question, Bug, or Feature?:

Feature

Virtual environments affected

  • macOS 10.15
  • Ubuntu 16.04 LTS
  • Ubuntu 18.04 LTS
  • Windows Server 2016 R2
  • Windows Server 2019

Expected behavior
A description of what you expected to happen.

There should always be at least X GB of free space.

Actual behavior
A description with steps to reproduce the issue. If your have a public example or repo to share,
please provide the link.

I don't think there are any safeguards besides customer's noticing and filing a bug.

@congyiwu
Copy link
Contributor Author

potentially also fail fast or warn really loudly if we're getting close to X GB

@miketimofeev
Copy link
Contributor

@congyiwu @nikita-bykov we shouldn't forget about additional 8Gb swap file on ubuntu, which is created later during VM provision

@congyiwu
Copy link
Contributor Author

Also if we switch to the temp disk (via a bind mount, symlink, or changing the working for to /mnt), that would obviate this issue

@nikita-bykov nikita-bykov added awaiting-deployment Code complete; awaiting deployment and/or deployment in progress and removed in development labels Apr 30, 2020
@nikita-bykov
Copy link
Contributor

We have added validation for available disk space.
Images with changes will be rolled out around next week.

@maxim-lobanov
Copy link
Contributor

Closing the issue since test works as expected on all images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Image administration awaiting-deployment Code complete; awaiting deployment and/or deployment in progress OS: Ubuntu OS: Windows
Projects
None yet
Development

No branches or pull requests

5 participants