Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brotli to linux images #1317

Merged
merged 1 commit into from
Jul 31, 2020
Merged

Conversation

vhiairrassary
Copy link
Contributor

@vhiairrassary vhiairrassary commented Jul 29, 2020

Description

Add brotli to linux images
Approximate size: 730.0 kB (Installed size in Ubuntu 20.04: https://packages.ubuntu.com/focal/brotli)

Tests should already be included: https://github.com/actions/virtual-environments/blob/main/images/linux/scripts/installers/basic.sh#L94-L101

Related issue: #1313

Check list

  • Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

@vhiairrassary
Copy link
Contributor Author

Is there a way to get ubuntu checks run on that PR?

@maxim-lobanov
Copy link
Contributor

/azp run ubuntu1604, ubuntu1804, ubuntu2004

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@vhiairrassary
Copy link
Contributor Author

@maxim-lobanov It seems there was an issue in the pipeline about geckodriver. I rebased the commit. Is it possible to trigger the pipelines?

@maxim-lobanov
Copy link
Contributor

Yep, it is known issue that was fixed recently by #1322
Could you please pull the latest master to your branch and I will restart builds? Sorry for inconvenience

@vhiairrassary
Copy link
Contributor Author

No problem. I rebased the branch, you can restart them

@maxim-lobanov
Copy link
Contributor

/azp run ubuntu1604, ubuntu1804, ubuntu2004

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@vhiairrassary
Copy link
Contributor Author

There was a conflict with yamllint (it has been merge few hours ago). Rebased & fixed.
Can someone launch the pipelines (it was ✅ for Ubuntu 20.04 in the previous check, other were still running)?

@maxim-lobanov maxim-lobanov merged commit 3542c55 into actions:main Jul 31, 2020
@vhiairrassary vhiairrassary deleted the patch-1 branch November 10, 2020 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants