-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround for apt db locked by WALinuxAgent #1883
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsame
requested review from
miketimofeev,
al-cheb,
AlenaSviridenko,
Darleev,
LeonidLapshin and
maxim-lobanov
October 23, 2020 04:32
tranb3o0920-hub
approved these changes
Oct 24, 2020
miketimofeev
approved these changes
Oct 26, 2020
AlenaSviridenko
approved these changes
Oct 26, 2020
/azp run ubuntu1604, ubuntu1804, ubuntu2004 |
Azure Pipelines successfully started running 3 pipeline(s). |
dmitry-shibanov
approved these changes
Oct 26, 2020
maxim-lobanov
requested changes
Oct 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't replace customer's apt command
Darleev
approved these changes
Oct 26, 2020
maxim-lobanov
approved these changes
Oct 28, 2020
1 task
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug fixing
WALinuxAgent running on agent hosts updates omsagent with apt related tools and locks apt database for a while. All the others attempts to instal/udate/remove apt packages fail.
The PR adds catch and retry logic by replacing the the real apt tools with custom scripts placed before the real binaries in the search path
Related issue: https://github.com/actions/virtual-environments-internal/issues/1339
Check list