Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Windows hostedtoolcache provisioner to GitHub Actions NPM registry #315

Conversation

vmapetr
Copy link
Contributor

@vmapetr vmapetr commented Jan 23, 2020

This PR switch Windows2016, Windows2019 toolcache provisioner to use Github Actions NPM registry.

Additional:

images/win/Windows2019-Azure.json Outdated Show resolved Hide resolved
images/win/scripts/Installers/Download-ToolCache.ps1 Outdated Show resolved Hide resolved
images/win/scripts/Installers/Download-ToolCache.ps1 Outdated Show resolved Hide resolved
images/win/toolcache-2019.json Outdated Show resolved Hide resolved
images/win/toolcache-2019.json Show resolved Hide resolved
@vmapetr vmapetr marked this pull request as ready for review January 28, 2020 09:33
images/win/Windows2019-Azure.json Show resolved Hide resolved
images/win/scripts/Installers/Download-ToolCache.ps1 Outdated Show resolved Hide resolved
images/win/toolcache-2019.json Show resolved Hide resolved
Copy link
Contributor

@sergey-akhalkov sergey-akhalkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, provided several nitpicks.

images/win/scripts/Installers/Download-ToolCache.ps1 Outdated Show resolved Hide resolved
images/win/scripts/Installers/Validate-ToolCache.ps1 Outdated Show resolved Hide resolved
@sergey-akhalkov sergey-akhalkov merged commit 0967620 into actions:master Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants