New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch Windows hostedtoolcache provisioner to GitHub Actions NPM registry #315
Merged
sergey-akhalkov
merged 22 commits into
actions:master
from
vmapetr:v-mapetr/improve-windows-toolcache-provisioner
Jan 29, 2020
Merged
Switch Windows hostedtoolcache provisioner to GitHub Actions NPM registry #315
sergey-akhalkov
merged 22 commits into
actions:master
from
vmapetr:v-mapetr/improve-windows-toolcache-provisioner
Jan 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rework validate toolcache script * Fix minor things
Update boost root folder path
al-cheb
reviewed
Jan 23, 2020
maxim-lobanov
requested changes
Jan 23, 2020
…s://github.com/vmapetr/virtual-environments into v-mapetr/improve-windows-toolcache-provisioner
al-cheb
reviewed
Jan 24, 2020
This reverts commit f279bd3.
al-cheb
approved these changes
Jan 28, 2020
miketimofeev
suggested changes
Jan 28, 2020
sergey-akhalkov
approved these changes
Jan 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, provided several nitpicks.
AlenaSviridenko
approved these changes
Jan 28, 2020
miketimofeev
approved these changes
Jan 28, 2020
MaksimZhukov
approved these changes
Jan 28, 2020
sergey-akhalkov
approved these changes
Jan 28, 2020
maxim-lobanov
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switch Windows2016, Windows2019 toolcache provisioner to use Github Actions NPM registry.
Additional: