Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Enable voiceover applescript defaults #4824

Merged
merged 3 commits into from
Jan 11, 2022

Conversation

cmorten
Copy link
Contributor

@cmorten cmorten commented Jan 1, 2022

Description

VoiceOver is a screen reader system application that provides auditory descriptions of elements help you easily navigate your screen with keyboard or gestures.

This PR extends the work of #4805 for enabling applescript control of voiceover by setting the required defaults for the key SCREnableAppleScript in com.apple.VoiceOver4/default.

Related issue:

Fixes #4770

Check list

  • Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

@@ -17,7 +17,9 @@ if [ -d "/Library/Application Support/VMware Tools" ]; then
sudo "/Library/Application Support/VMware Tools/vmware-resolutionSet" 1176 885
fi

# Update VoiceOver Utility to allow VoiceOver to be controlled with AppleScript by creating a special file (SIP must be disabled)
# Update VoiceOver Utility to allow VoiceOver to be controlled with AppleScript by updating defaults and creating a special file (SIP must be disabled)
defaults write com.apple.VoiceOver4/default SCREnableAppleScript -bool YES
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this command to if block at line 23

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to, but may I ask why? As far as I’m aware this command updating defaults doesn’t require SIP to be disabled, so guarding it behind the csrutil status check could be misleading. Is it simply to keep the two VO commands in lockstep? Either you get both or neither?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmorten , Oh, I see. In that case, could you add a comment to describe why we need this command? Because currently the comment above contains (SIP must be disabled) description.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, that description is now somewhat misleading, I’ll have a think and push something up!

@al-cheb al-cheb requested a review from a team January 10, 2022 06:29
@miketimofeev
Copy link
Contributor

/azp run macos11, macos12

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update VoiceOver Utility to allow VoiceOver to be controlled with AppleScript
3 participants