-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[macOS] Enable voiceover applescript defaults #4824
[macOS] Enable voiceover applescript defaults #4824
Conversation
@@ -17,7 +17,9 @@ if [ -d "/Library/Application Support/VMware Tools" ]; then | |||
sudo "/Library/Application Support/VMware Tools/vmware-resolutionSet" 1176 885 | |||
fi | |||
|
|||
# Update VoiceOver Utility to allow VoiceOver to be controlled with AppleScript by creating a special file (SIP must be disabled) | |||
# Update VoiceOver Utility to allow VoiceOver to be controlled with AppleScript by updating defaults and creating a special file (SIP must be disabled) | |||
defaults write com.apple.VoiceOver4/default SCREnableAppleScript -bool YES |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this command to if block at line 23
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to, but may I ask why? As far as I’m aware this command updating defaults doesn’t require SIP to be disabled, so guarding it behind the csrutil status
check could be misleading. Is it simply to keep the two VO commands in lockstep? Either you get both or neither?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cmorten , Oh, I see. In that case, could you add a comment to describe why we need this command? Because currently the comment above contains (SIP must be disabled)
description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, that description is now somewhat misleading, I’ll have a think and push something up!
/azp run macos11, macos12 |
Azure Pipelines successfully started running 2 pipeline(s). |
Description
VoiceOver is a screen reader system application that provides auditory descriptions of elements help you easily navigate your screen with keyboard or gestures.
This PR extends the work of #4805 for enabling applescript control of voiceover by setting the required defaults for the key
SCREnableAppleScript
incom.apple.VoiceOver4/default
.Related issue:
Fixes #4770
Check list