New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Microsoft SQL Server Express to Windows VMs #568

Merged

AlenaSviridenko merged 52 commits into actions:master from Darleev:v-danurg/install_sql_express

Mar 30, 2020

Contributor

Darleev commented Mar 16, 2020 •

edited

A pull request for the issue: #413 Add Microsoft SQL Express to Windows VMs

Disk Space: 500 Mb
Installation time: 5 minutes

Link to successful canary build with current scripts.

Dariy.Nurgaleev added 3 commits

March 12, 2020 21:22


          added SQL Express install step

cde2e7d


          Added SQL Express installation

a318add


          SQLExpress installation full process

debb478

Darleev requested review from al-cheb, miketimofeev, sergey-akhalkov, AlenaSviridenko, alepauly, maxim-lobanov, andy-mishechkin and m-minasyan

March 16, 2020 18:45

al-cheb reviewed

View reviewed changes

images/win/scripts/Installers/Install-SQLExpress.ps1 Outdated Show resolved Hide resolved

al-cheb reviewed

View reviewed changes

images/win/scripts/Installers/Validate-SQLExpress.ps1 Outdated Show resolved Hide resolved

al-cheb reviewed

View reviewed changes

images/win/scripts/Installers/Install-SQLExpress.ps1 Outdated Show resolved Hide resolved

al-cheb reviewed

View reviewed changes

images/win/scripts/Installers/Validate-SQLExpress.ps1 Outdated Show resolved Hide resolved

al-cheb reviewed

View reviewed changes

images/win/scripts/Installers/Install-SQLExpress.ps1 Outdated Show resolved Hide resolved

al-cheb reviewed

View reviewed changes

images/win/scripts/Installers/Install-SQLExpress.ps1 Outdated Show resolved Hide resolved

al-cheb reviewed

View reviewed changes

images/win/scripts/Installers/Install-SQLExpress.ps1 Outdated Show resolved Hide resolved

al-cheb reviewed

View reviewed changes

images/win/scripts/Installers/Install-SQLExpress.ps1 Outdated Show resolved Hide resolved

miketimofeev suggested changes

View reviewed changes

images/win/scripts/Installers/Validate-SQLExpress.ps1 Outdated Show resolved Hide resolved

Dariy.Nurgaleev added 9 commits

March 17, 2020 21:47


          re-worked SQLExpress installer

1cb09f8


          added messages

6b8ec80


          added debug messages


          changed if statement

a64115f


          validation with function

8354d1a


          added description for SQL Express scripts

02154aa


          added software markdon

c279ba0


          changed comment for SQL Express install

b2c676b


          added retry logic for download

81872a6

al-cheb reviewed

View reviewed changes

images/win/scripts/Installers/Validate-SQLExpress.ps1 Outdated Show resolved Hide resolved

Dariy.Nurgaleev added 2 commits

March 20, 2020 19:09


          fix for installerPath

25fabc3


          added resultPath to resolve the issue

66a7126

sergey-akhalkov reviewed

View reviewed changes

images/win/scripts/ImageHelpers/InstallHelpers.ps1 Show resolved Hide resolved

images/win/scripts/Installers/Install-SQLExpress.ps1 Show resolved Hide resolved

Dariy.Nurgaleev and others added 13 commits

March 24, 2020 12:50


          added comment

1dcacb7


          short list

98077f0


          added variable for current position

e387112


          added file content

aac8f5b


          Need to move out system directory

409a201


          change pathes to avoid installation problems

bbf8c7f


          added new variable to FullSQLPackage function

770a415


          cleanup installation folder.

827d2ca


          add comments for all steps

739bbe2


          changed installation packages and cleanup

d3ab1f0


          small changes for scripts.

dd93159


          resolve cpnflicts

5dadce6


          Windows2019 file was corrupted

2c98daa

Darleev requested a review from sergey-akhalkov

March 24, 2020 10:45

Dariy.Nurgaleev added 3 commits

March 24, 2020 17:50


          fixed Install-Wix change.

20f0972


          applied proper changes for Windows2019

d9c166b


          added mkdir instetad of md

0bf0614

Contributor

alepauly commented Mar 25, 2020

/azp run windows2016, windows2019

azure-pipelines bot commented Mar 25, 2020

Azure Pipelines successfully started running 2 pipeline(s).

alepauly approved these changes

View reviewed changes

Dariy.Nurgaleev added 2 commits

March 27, 2020 12:52


          removed all mandatory parameters to verify build.

8ecd0d9


          Merge branch 'master' into v-danurg/install_sql_express

d062075

sergey-akhalkov approved these changes

View reviewed changes

maxim-lobanov reviewed

View reviewed changes

images/win/scripts/Installers/Install-SQLExpress.ps1 Outdated Show resolved Hide resolved


          Create directory using native powershell tools

a48d21f

AlenaSviridenko merged commit e6f803a into actions:master

miketimofeev mentioned this pull request

Windows build changes without a release log #691

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

maxim-lobanov maxim-lobanov approved these changes

sergey-akhalkov sergey-akhalkov approved these changes

alepauly alepauly approved these changes

m-minasyan m-minasyan approved these changes

AlenaSviridenko Awaiting requested review from AlenaSviridenko

andy-mishechkin Awaiting requested review from andy-mishechkin

miketimofeev Awaiting requested review from miketimofeev

al-cheb Awaiting requested review from al-cheb