Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should formatting run before getItemKey? #16

Closed
grantcodes opened this issue Nov 9, 2020 · 3 comments
Closed

Should formatting run before getItemKey? #16

grantcodes opened this issue Nov 9, 2020 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@grantcodes
Copy link

Description

I'm trying to use the api poll trigger to query a json list of upvoted posts (available from https://www.reddit.com/prefs/feeds/).
But the json is quite complicated, so I used the itemsPath and format options to simplify things, but I think the deduplicationKey uses the unprocessed json, which constantly changes and has the id property as a nested item.

If the json formatting was run before the deduplication the poll trigger could be used for much more complicated json.

@grantcodes grantcodes added the help wanted Extra attention is needed label Nov 9, 2020
@theowenyoung
Copy link
Member

Hi, @grantcodes , yes, I think you're right, format and filtetOutputs should be run at the first, not it run at the last. I'll give a fix today, and the deduplicationKey should support path param like data.id, so, it can support more complex situations.

@theowenyoung
Copy link
Member

@grantcodes Hi, I just released a new version, format will be run at the first, deduplicationKey is also support path format. Now you can try it. Let me know if you have any further question.

@grantcodes
Copy link
Author

Thanks @theowenyoung it's working great now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants