Should call ByteBuf.recycle() after read data?

[azzahrah]

Should we recycle after read incoming data

 public static ByteBufsDecoder<ByteBuf> customDecoder(int maxSize) {

        return bufs -> {

            if (bufs.remainingBytes() < 5) {
                return null;
            }

            int length = 2 + 2; //header tail
            if (bufs.peekByte(0) == 0x78 && bufs.peekByte(1) == 0x78) {
                length += 1 + bufs.peekByte(2);
            } else if (bufs.peekByte(0) == 0x79 && bufs.peekByte(1) == 0x79) {
                length += 2 + bufs.peekByte(2);
            }

            if (bufs.remainingBytes() < length) {
                return null;
            }
            //ByteBuf temp = ByteBufPool.allocate(length);
            //bufs.drainTo(temp);
            //return temp;
            return bufs.takeExactSize(length);
        };
    }

Main App

 public static void main(String[] args) throws Exception {
        Eventloop eventloop = Eventloop.create().withCurrentThread();
        SimpleServer server = SimpleServer.create(eventloop, new Consumer<AsyncTcpSocket>() {
            @Override
            public void accept(AsyncTcpSocket socket) {
                
                // readData(socket);
                BinaryChannelSupplier
                        .of(ChannelSupplier.ofSocket(socket))
                        .decodeStream(customDecoder(1024))
                        .streamTo(ChannelConsumer.ofConsumer((data) -> {
                            //read data....
                            //should i call data.recycle() after read data?

                            data.recycle(); // Is this right?
                        }));
            }
        });
        server.withListenPort(PORT);
        server.listen();

        System.out.println("Server is running");
        System.out.println("You can connect from telnet with command: telnet localhost 9922 or by running csp.TcpClientExample");

        eventloop.run();
    }

"To make everything consistent, ActiveJ relies on the concept of ‘ownership’ (like in Rust language) - after allocation, the components pass a byteBuf from one to another, until the last ‘owner’ recycles it to ByteBufPool."

after read data? should call ByteBuf.recycle()? how about when client disconnect, shoudl activej recycle all buf have been used?

[eduard-vasinskyi]

Hello, @azzahrah
Yes, you should recycle a ByteBuf once you have read data from it and not planning to use it anymore. This way you will ease Java’s garbage collection and overall memory pressure. If you do not recycle a ByteBuf, it will still be collected during GC (if there are no references to the ByteBuf).
ActiveJ recycles all of the internal ByteBufs once they are not needed (e.g. connection closes, component shutdowns).

[azzahrah]

@eduard-vasinskyi , thank for your answer this clear for me.... this like ReleaseReference counting in netty

[eduard-vasinskyi]

@azzahrah, yes, ByteBuf counts its references and returns buf to the pool once it reaches zero.