Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Append MPL headers on source #476

Closed
1 task done
mynameisvinn opened this issue Jan 20, 2021 · 20 comments
Closed
1 task done

[FEATURE] Append MPL headers on source #476

mynameisvinn opened this issue Jan 20, 2021 · 20 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@mynameisvinn
Copy link
Contributor

mynameisvinn commented Jan 20, 2021

馃毃馃毃 Feature Request

  • A new implementation (Improvement, Extension)

Is your feature request related to a problem?

Hub currently uses Mozilla Public License (MPL), which requires the following header (from Exhibit A of the license) to be attached to source.

This Source Code Form is subject to the terms of the Mozilla Public License, v. 2.0. If a copy of the MPL was not distributed with this file, You can obtain one at https://mozilla.org/MPL/2.0/.

We need help appending MPL headers on source (where appropriate).

@KrishnaChaitanya1
Copy link
Contributor

Hi @mynameisvinn I am interested to this but I'm new. Could you explain this in detail?

@haiyangdeperci
Copy link
Contributor

Hi @KrishnaChaitanya1 thanks for willing to contribute. Essentially, you need to copy the header mentioned by @mynameisvinn and place it at the top of each of the source files. Would you like to be assigned on this issue?

@KrishnaChaitanya1
Copy link
Contributor

Hi @haiyangdeperci . Sure assign it to me, let me give it a shot

@haiyangdeperci
Copy link
Contributor

@KrishnaChaitanya1 done, thanks for helping us 馃憤

@mynameisvinn
Copy link
Contributor Author

@KrishnaChaitanya1 let me know if you run into problems. Good luck!

@BraveStone9
Copy link

is this issue closed or I can still work on it. This is my first time contributing to an open-source project want to start from somewhere.

@mynameisvinn
Copy link
Contributor Author

Hi @BraveStone9 we could definitely use your help!

@KrishnaChaitanya1 mind giving us an update? That way we can resolve this issue together :)

@KrishnaChaitanya1
Copy link
Contributor

Hi @mynameisvinn I have completed adding them, I am pushing them to my forked repo so that you guys can look into it.

@haiyangdeperci
Copy link
Contributor

@KrishnaChaitanya1 Great, thanks so much for helping us! Could you send us a link? I've looked through your fork and I haven't seen any new comments.

@KrishnaChaitanya1
Copy link
Contributor

@haiyangdeperci I am yet to push. when I ran the pytest command as mentioned in the Contributions.md, I am getting few errors. I am sorting them out

@haiyangdeperci
Copy link
Contributor

haiyangdeperci commented Jan 25, 2021

@KrishnaChaitanya1 all rights, no worries 馃憤 Let us know if you need any help.

@haiyangdeperci
Copy link
Contributor

Hi @BraveStone9 Perhaps #393 could work for you? Would you like to be assigned?

@KrishnaChaitanya1
Copy link
Contributor

Hi @haiyangdeperci. I pushed the changes I made to my fork. Could you check and let me know if everything is fine?

@BraveStone9
Copy link

@haiyangdeperci sure, I can give it a try!

@KrishnaChaitanya1
Copy link
Contributor

@haiyangdeperci .While executing pytest command, I encountered the following errors.
Pytest
Is this okay or should some changes need to be made?

@haiyangdeperci
Copy link
Contributor

haiyangdeperci commented Jan 25, 2021

@KrishnaChaitanya1 I'll take a look in a moment.
@BraveStone9 all right, go for it, comment over there for assignment

@haiyangdeperci
Copy link
Contributor

@KrishnaChaitanya1 could you remove test/filtering2/meta.json and the like files from the commit? That might be a fix. Afterwards, make a PR. It'd be easier to check the with the CI output

@KrishnaChaitanya1
Copy link
Contributor

KrishnaChaitanya1 commented Jan 25, 2021

@haiyangdeperci . Should I PR in the main hub repo or my fork? Sorry if I am asking simple questions. I am new to these :)
Edit: I did the PR. Have a look at it and let me know

@haiyangdeperci
Copy link
Contributor

@KrishnaChaitanya1 great, taking a look!

@haiyangdeperci
Copy link
Contributor

Fixed by #494

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants