Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix segf #1326

Merged
merged 4 commits into from Nov 8, 2021
Merged

fix segf #1326

merged 4 commits into from Nov 8, 2021

Conversation

farizrahman4u
Copy link
Contributor

馃殌 馃殌 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

@CLAassistant
Copy link

CLAassistant commented Nov 8, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

@farizrahman4u farizrahman4u marked this pull request as ready for review November 8, 2021 06:19
@farizrahman4u farizrahman4u changed the base branch from main to feature/text-signwal November 8, 2021 07:25
@farizrahman4u farizrahman4u merged commit 03f8c90 into feature/text-signwal Nov 8, 2021
@farizrahman4u farizrahman4u deleted the fr_fix_segf branch November 8, 2021 07:26
AbhinavTuli added a commit that referenced this pull request Nov 8, 2021
@AbhinavTuli @farizrahman4u
Added text signwall within Hub (#1323)
ff3a76a 
* added signwall

* better logout

* add agreement using api

* don't ask creator for agreement

* cleanup

* added tests

* removed unused import

* update test

* fix lot of linting

* fix segf (#1326)

* skip audio test for linux py3.6 (#1327)

Co-authored-by: Fariz Rahman <farizrahman4u@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhinavTuli AbhinavTuli AbhinavTuli approved these changes

@tatevikh tatevikh tatevikh approved these changes

@jraman jraman Awaiting requested review from jraman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@farizrahman4u @CLAassistant @AbhinavTuli @tatevikh @istranic