Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activemerchant Credit Card object to support encrypted number #4280

Closed
artimys opened this issue Jan 18, 2022 · 1 comment
Closed

Activemerchant Credit Card object to support encrypted number #4280

artimys opened this issue Jan 18, 2022 · 1 comment
Labels

Comments

@artimys
Copy link

artimys commented Jan 18, 2022

I was looking to add a PR to support an encrypted card number in the PayTrace gateway to stay out of scope in PCI compliance. PayTrace has a JS ClientSide Encryption Library, more info.

But looking at the Activemerchant Credit Card object:

  • #number strips away characters leaving only numbers. (see file)
  • #track_data doesn't strip the value's content but doesn't hold a meaningful name for a crypted number.

So I'm thinking of adding attr_accessor :encrypted_number to active_merchant billing credit card object but wanted to get some thoughts on this before adding a change request or if anyone has a better solution.

Thoughts?

Copy link

github-actions bot commented May 2, 2024

To provide a cleaner slate for the maintenance of the library, this PR/Issue is being labeled stale after 60 days without activity. It will be closed in 14 days unless you comment with an update regarding its applicability to the current build. Thank you!

@github-actions github-actions bot added the Stale label May 2, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant