QuickPay billing integrations is missing "acquirer" when computing callback notification response md5 check.

[naoufalmed]

Hi,

When using QuickPay billing integration, I use ActiveMerchant::Billing::Integrations::Quickpay::Notification class to process the callback response, but the calling to the method acknowledge always returns false. Comparing the MD5_CHECK_FIELDS constant with the required fields for computing the md5 checksum, I see that the field acquirer is missing in the constant.
Here is what the documentation says:

You can perform you own MD5 check on the data returned to you. An example of MD5 calculation from the above listed values, could look like this and remember to calculate the values in the correct order (msgtype, ordernumber, amount, currency, time, state, qpstat, qpstatmsg, chstat, chstatmsg, merchant, merchantemail, transaction, cardtype, cardnumber, card expire, acquirer , splitpayment, fraudprobability, fraudremarks, fraudreport, fee, secret)

But in ActiveMerchant::Billing::Integrations::Quickpay::Notification the fields are as follows:

MD5_CHECK_FIELDS = [
            :msgtype,
            :ordernumber,
            :amount,
            :currency,
            :time,
            :state,
            :qpstat,
            :qpstatmsg,
            :chstat,
            :chstatmsg,
            :merchant,
            :merchantemail,
            :transaction,
            :cardtype,
            :cardnumber,
            :cardhash,
            :cardexpire,
            :splitpayment,
            :fraudprobability,
            :fraudremarks,
            :fraudreport,
            :fee
          ]

As you can see the :acquirer field is missing.

Is that correct or I'm using the wrong class?

Thank you!

[ntalbott]

ActiveMerchant integrations have been extracted into https://github.com/Shopify/offsite_payments. This PR has been moved (via reference) to the new repo - please follow up on it there.