Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gem getting heavier #407

Closed
larouxn opened this issue Feb 8, 2021 · 3 comments
Closed

Gem getting heavier #407

larouxn opened this issue Feb 8, 2021 · 3 comments

Comments

@larouxn
Copy link
Collaborator

larouxn commented Feb 8, 2021

According to rubygems.org/gems/payment_icons/versions, the gem has gotten quite a bit heavier recently. May be due tot he addition of several base64 png encoded icons as many were added in #393 and released as party of v1.5.7.
Screen Shot 2021-02-08 at 13 42 07

@tauthomas01
Copy link
Collaborator

I noticed as well lately that many merged PRs were using base64 png icon, which I have concerns. Should we enforce to use proper SVG tags (<circle>, <path>...) instead of base64 png format?

@larouxn
Copy link
Collaborator Author

larouxn commented Feb 9, 2021

Hmm, SVG only would certainly cut down on size but there are definitely icons for which people won't be able to find SVGs. 🤔

That said, considering this size increase is from just 10-20 recent icons I think we need to aim to enforce SVG only going forward.

@larouxn
Copy link
Collaborator Author

larouxn commented Sep 8, 2021

Closing this for now. Let's just ensure we only accept SVGs going forward unless absolutely critical.

@larouxn larouxn closed this as completed Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants