Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: http body editor is not properly aligned. #1597

Closed
tolgaulas opened this issue Jul 2, 2023 · 9 comments · Fixed by #1693
Closed

[BUG]: http body editor is not properly aligned. #1597

tolgaulas opened this issue Jul 2, 2023 · 9 comments · Fixed by #1693
Assignees
Labels
🤷‍♂️ action required Further action or information required 🤷‍♂️🤷‍♀️ untriaged Need attention from maintainer in activepieces

Comments

@tolgaulas
Copy link

Describe the bug
The texts are not justified in the body editor of "send http request"

To Reproduce
Steps to reproduce the behavior:

  1. Create an HTTP request, set type post and edit body to be send.

Expected behavior
The editor lines should properly displayed after the line numbers.

Screenshots
image
Additional context
Tried both on chrome, firefox and brave browsers.

@abuaboud abuaboud added the 🤷‍♂️🤷‍♀️ untriaged Need attention from maintainer in activepieces label Jul 2, 2023
@abuaboud
Copy link
Contributor

abuaboud commented Jul 2, 2023

@AbdulTheActivePiecer Can you please take look

@abuaboud abuaboud added the 🤷‍♂️ action required Further action or information required label Jul 2, 2023
@tolgaulas
Copy link
Author

This fixes it in my browser (setting left to 0px): <div class="CodeMirror-gutters" style="height: 96px; left: 0px;" .....

@tolgaulas
Copy link
Author

Same issue with the advanced mapping too. Probably the same shared subcomponent.

@tolgaulas
Copy link
Author

Same issue with the advanced mapping too. Probably the same shared subcomponent.

yet the above does not solve this time.. Also see this : mdn/bob#976 (comment)

@tolgaulas
Copy link
Author

I see its not 6 (https://github.com/activepieces/activepieces/blob/main/package.json#L63) , would you pls consider to update it?

@tolgaulas
Copy link
Author

tolgaulas commented Jul 2, 2023

Hm. I see you also use ngx-codemirror which looks like limited to 5 only.. Sad.. May I suggest switching to ACE (which also has ngx- wrapper, because of this : scttcper/ngx-codemirror#311 (comment)).

@abuaboud
Copy link
Contributor

@AbdulTheActivePiecer I have seen you mentioned this issue, Is it solved?

@AbdulTheActivePiecer
Copy link
Collaborator

No it was a mistake, that got mentioned, will check it out today.

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If this issue is continuing with the lastest stable version of Activepieces, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤷‍♂️ action required Further action or information required 🤷‍♂️🤷‍♀️ untriaged Need attention from maintainer in activepieces
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants