Skip to content
This repository has been archived by the owner on Mar 30, 2022. It is now read-only.

meta_where slowing down my test suite using ruby 1.9.2 #18

Closed
alissonsales opened this issue Apr 25, 2011 · 3 comments
Closed

meta_where slowing down my test suite using ruby 1.9.2 #18

alissonsales opened this issue Apr 25, 2011 · 3 comments

Comments

@alissonsales
Copy link

There's something wrong with the lib when using it with ruby 1.9.2. My test suite started to become slow after we added meta_where on the project. Please check this thread on rspec-users http://groups.google.com/group/rspec/browse_thread/thread/7f408d69bd7ea09
and the results I was getting with the gem https://gist.github.com/939699

@ernie
Copy link

ernie commented Apr 25, 2011

I'm sorry, this is insufficient information for me to act on. I use MetaWhere in several production systems on 1.9.2 without issue, and I can't imagine any difference in behavior between Ruby implementations that would cause the degradation you're seeing.

If you can do some Benchmark runs that can demonstrate specific areas of decreased performance under 1.9.2, I'd be happy to take another look, but an rspec profile isn't enough to go on, particularly since the slowdowns only seem to happen under rspec.

@ernie ernie closed this as completed Apr 25, 2011
@ernie ernie reopened this Apr 25, 2011
@ernie
Copy link

ernie commented Apr 25, 2011

I'm going to reopen this since I just got a report of something similar on Squeel. What I need, though, is some way to reproduce this locally. I don't use RSpec on any of my actual Rails apps, so I don't have a clear test case at this point, which is going to make tracking this down pretty much like looking for a needle in a haystack.

@ernie
Copy link

ernie commented May 6, 2011

I found and fixed the problem in Squeel, but as far as I can tell, there's no such similar issue in MetaWhere. If you can provide a project that demonstrates the issue, I'll do my best to tackle it, but barring that, I'm closing this issue.

@ernie ernie closed this as completed May 6, 2011
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants