Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme instructions to not add any other dependencies #58

Open
activescott opened this issue Sep 18, 2021 · 2 comments
Open

update readme instructions to not add any other dependencies #58

activescott opened this issue Sep 18, 2021 · 2 comments

Comments

@activescott
Copy link
Owner

it seems by just declaring the proper peer dependencies npm now will install it in the parent project ok?

@activescott
Copy link
Owner Author

at least it works in activescott/diag

@activescott
Copy link
Owner Author

activescott commented Sep 19, 2021

so it worked locally without adding dependencies in node@16 but in a github actions with node@12 it failed without adding prettier, eslint, @typescript-eslint/eslint-plugin, eslint-config-prettier, @typescript-eslint/parser dev dependencies...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant