Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all frontend dependencies explicit version numbers rather than minimums #872

Open
2 tasks done
andrewtavis opened this issue May 3, 2024 · 5 comments
Open
2 tasks done
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

andrewtavis commented May 3, 2024

Terms

Description

The way that we've been doing frontend dependencies for the longest time is to have a minimum version number and let yarn figure out the rest. An issue with this is that it's making maintaining PRs for the frontend dramatically more difficult, as each time there's an added dependency we also get minor version updates that lead to overly complex merge conflicts with yarn.lock. With this in mind, it'd be great to have only explicit version numbers for the frontend in the pageage.json file.

We can set all current minimums as the explicit version number and work it out until we have a working build, and then from there we can update them regularly as needed :)

Note - related issues are:

Contribution

Happy to support or work on this myself eventually! 😊

@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels May 3, 2024
@andrewtavis
Copy link
Member Author

CC @aasimsyed again :) Thanks for the chats on dependencies and for your work on that there yarn.lock! Let's try to have you not need to do that again :)

@andrewtavis
Copy link
Member Author

One thing that's needed from here is also removing all of the packages that we don't need except to suppress the warnings :)

@tasawar-hussain
Copy link

I would like to take it up!

@andrewtavis
Copy link
Member Author

Hey @tasawar-hussain 👋 Thanks for the interest! We talked yesterday that @aasimsyed was going to take this one, but I'll get you on the other two you wrote in :)

@andrewtavis
Copy link
Member Author

@aasimsyed, can you write in here and I'll assign?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: Todo
Development

No branches or pull requests

2 participants