Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESM hotkey does not prevent keystroke from being applied #4

Open
acrule opened this issue Jul 17, 2014 · 3 comments
Open

ESM hotkey does not prevent keystroke from being applied #4

acrule opened this issue Jul 17, 2014 · 3 comments
Labels

Comments

@acrule
Copy link

acrule commented Jul 17, 2014

The current use of NSEvent.addGlobalMonitorForEventsMatchingMask_() to capture the ESM "hotkey" of Cmd-Shift-Enter does not intercept the keystroke but only listens for it. This means the keystroke will still be sent to the current application (sending Enter to a text editor for example).

We should consider using the Carbon API or https://github.com/davedelong/DDHotKey to implement a more robust hotkey that intercepts the keystroke.

@acrule acrule added the bug label Jul 17, 2014
@acrule
Copy link
Author

acrule commented Jul 18, 2014

Seems that Quartz Taps handle whole classes of events (Keyup, keydown, Mousedown) and can only be made to listen or intercept these classes rather than more specific events (like Cmd-Shift-Enter).

The other option is to use Carbon APIs as in the link below, but these APIs seem depricated:

https://pythonhosted.org/pyobjc/examples/Cocoa/AppKit/HotKeyPython/index.html

@acrule
Copy link
Author

acrule commented Jan 12, 2015

This is now an issue with the bookmark hotkey, which is currently Shift + CMD + Enter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant