Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codec: Framed::poll_ready does not register waker #406

Closed
thalesfragoso opened this issue Nov 1, 2021 · 0 comments · Fixed by #409
Closed

Codec: Framed::poll_ready does not register waker #406

thalesfragoso opened this issue Nov 1, 2021 · 0 comments · Fixed by #409

Comments

@thalesfragoso
Copy link
Member

It returns Poll::Pending without registering the waker:

fn poll_ready(self: Pin<&mut Self>, _: &mut Context<'_>) -> Poll<Result<(), Self::Error>> {
if self.is_write_ready() {
Poll::Ready(Ok(()))
} else {
Poll::Pending
}
}

This might be the cause of actix/actix#431, as noted by fakeshadow.

CC @elpiel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant