actix-web returns 404 instead of 405 for unsupported verbs on resources

[vmalloc]

The following example illustrates the issue:

use actix_web::{web, App, HttpServer, Responder};

async fn index() -> impl Responder {
    ...
}

#[actix_rt::main]
async fn main() -> std::io::Result<()> {
    HttpServer::new(|| {
        App::new()
            .route("/index", web::get().to(index))
    })
    .bind("127.0.0.1:8000")?
    .run()
    .await
}

Attempting to send a POST /index will fail with 404, where 405 is actually the appropriate error code for such a case.

This is a regression compared to 1.x, as I previously reported the same issue...

[fafhrd91]

Could you submit pr with unit test?

[vmalloc]

Sure. You mean submit the fix as well? I'm not sure I know where the relevant code is

[fafhrd91]

Fix would good as well

[vmalloc]

Ok, I'll try...

[vmalloc]

@fafhrd91 I have the unit test written down, but I don't understand how to fix https://github.com/actix/actix-web/blob/9eedd010516dbc56a218e9d8c34f3a2e13c6faec/src/app_service.rs#L73 so that if any paths matched with incorrect methods it should selectively return 405... Just changing it to return 405 breaks other behaviors, and I couldn't figure out how to apply the fix you made in ffb3324 to this scenario....

[yim7]

That is because App::route() adds all guards to the Resource, so resouce check guards failed and the app's default device is actually called. If we can combine resource with same path into one, there is no need to add guards in routes to resource, just like registering routes with resouce directly.

    pub fn route(self, path: &str, mut route: Route) -> Self {
        self.service(
            Resource::new(path)
                .add_guards(route.take_guards())
                .route(route),
        )
    }

[robjtede]

I've run across this and feel like its intended behavior. There should be a way to "hide" verbs on routes. If you want 405s use a web::resource instead. Is this reasonable?

[vmalloc]

@robjtede that seems like a reasonable compromise to me. Thanks!