Host header does not comply with RFC2616

[Paradyx]

Sending a request to a host on a port other then 80 should change the host header according to RFC2616 14.23 Host
i.e.: Connecting to localhost:8081 should write the header host: localhost:8081 and not host: localhost

[DoumanAsh]

Isn't port optional though?

[Paradyx]

RFC states

A "host" without any trailing port information implies the default port for the service requested

And I have a server here which rejects my request when not setting the host header correctly.

[DoumanAsh]

Ah, I understand the implication, but what I say is that it is not MUST to specify port :)

So you would like default host to be set according to remote domain name and port, used for connection
automatically?
It is quite rare to run server on non-80 port, but I guess we could do it.

Just for your interest, HOST is set, if it is omitted, here https://github.com/actix/actix-web/blob/master/src/client/request.rs#L629-L640

[Paradyx]

That would be great 👍

[DoumanAsh]

@Paradyx If you have time, you could do it youself, PRs are welcome 😄

I'll take a look at it later one, after work

[DoumanAsh]

@Paradyx Btw should we omit port in header when we use default HTTPs port too? 😄