Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider updating actix-derive to use syn@2 #552

Closed
LikeLakers2 opened this issue Apr 1, 2023 · 2 comments
Closed

Consider updating actix-derive to use syn@2 #552

LikeLakers2 opened this issue Apr 1, 2023 · 2 comments
Labels
A-derive Crate: actix-derive good first issue

Comments

@LikeLakers2
Copy link

Hi! I noticed that actix-derive depends on syn@1. Perhaps you could consider updating it to use syn@2?

Some things worth noting for anyone who intends to take on this suggestion:

  • syn@2's MSRV is Rust 1.56, up from syn@1's Rust 1.31. I am unsure how this fits with actix-derive, however I do note that actix's MSRV is 1.57 (according to the repository README), which probably means this shouldn't be a problem?
  • Updating to syn@2 may not be as simple as swapping the version number - there are a number of breaking changes in syn@2, listed at https://github.com/dtolnay/syn/releases/tag/2.0.0.

If you do consider to transition to syn@2, you have my thanks! :)

@robjtede robjtede added good first issue A-derive Crate: actix-derive labels Apr 1, 2023
@LikeLakers2
Copy link
Author

@robjtede Ah, sorry for saying this sort of late, but I wouldn't label this as a "good first issue". I misunderstood how many changes would need to be made, and how much of what equates to a new architecture would need to be understood - and this only occurred to me after someone pointed it out on the issue I left on the Bevy Engine repository. bevyengine/bevy#8282 (comment)

@robjtede
Copy link
Member

done in #554

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-derive Crate: actix-derive good first issue
Projects
None yet
Development

No branches or pull requests

2 participants