Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add seeding python example + tests #1026

Merged
merged 4 commits into from
Oct 14, 2021

Conversation

paulgessinger
Copy link
Member

This PR adds a python based seeding example and a test that asserts its output.

@paulgessinger paulgessinger added this to the next milestone Oct 6, 2021
@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #1026 (a448ca2) into main (78dc391) will not change coverage.
The diff coverage is n/a.

❗ Current head a448ca2 differs from pull request most recent head fd68f55. Consider uploading reports for the commit fd68f55 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1026   +/-   ##
=======================================
  Coverage   48.62%   48.62%           
=======================================
  Files         337      337           
  Lines       17334    17334           
  Branches     8192     8192           
=======================================
  Hits         8428     8428           
  Misses       3164     3164           
  Partials     5742     5742           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78dc391...fd68f55. Read the comment docs.

Copy link
Contributor

@robertlangenberg robertlangenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@paulgessinger
Copy link
Member Author

@robertlangenberg I had to update and resolve conflicts. Can you re-approve?

@paulgessinger paulgessinger enabled auto-merge (squash) October 12, 2021 08:37
@paulgessinger paulgessinger changed the title feat: Add seeding python example + tests feat: Add seeding python example + testsx Oct 12, 2021
@paulgessinger paulgessinger changed the title feat: Add seeding python example + testsx feat: Add seeding python example + tests Oct 12, 2021
@paulgessinger paulgessinger merged commit 104eb14 into acts-project:main Oct 14, 2021
@paulgessinger paulgessinger modified the milestones: next, v14.1.0 Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants