refactor: Remove the SmearingAlgorithm #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1041 +/- ##
=======================================
Coverage 48.60% 48.60%
=======================================
Files 337 337
Lines 17335 17335
Branches 8192 8192
=======================================
Hits 8425 8425
Misses 3172 3172
Partials 5738 5738 Continue to review full report at Codecov.
|
paulgessinger
approved these changes
Oct 13, 2021
There was a problem hiding this comment.
In combination with #1040, this looks like the way to go to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SmearingAlgorithm is obsoleted by the hybrid DigitizationAlgorithm, therefore this PR removes it enterely.
in #955, the issue of documenting the new .json format was raised. I have created a WIP PR, #1040, which adds a python script that uses the old cli switches to bootstrap a .json file, if we want to to this route.
closes #955
Ping @asalzburger @paulgessinger