docs: Inprovement of the material mapping how-to #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1051 +/- ##
=======================================
Coverage 48.57% 48.57%
=======================================
Files 338 338
Lines 17343 17343
Branches 8200 8200
=======================================
Hits 8425 8425
Misses 3180 3180
Partials 5738 5738 Continue to review full report at Codecov.
|
paulgessinger
approved these changes
Oct 25, 2021
Co-authored-by: Paul Gessinger <hello@paulgessinger.com>
|
@paulgessinger since I implemented your changes I think you need to reapprove. |
paulgessinger
approved these changes
Oct 26, 2021
paulgessinger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the material mapping how-to. It provided context on what material mapping is and why is it needed, gives some pointer to how the map should be configured and explain that in the case of DD4Hep the config is not always needed (this should resolve #899 ).