feat!: changed Grid interface of neighborHoodIndices #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d upper neighbors
paulgessinger
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1052 +/- ##
==========================================
- Coverage 48.57% 48.57% -0.01%
==========================================
Files 338 338
Lines 17343 17369 +26
Branches 8200 8216 +16
==========================================
+ Hits 8425 8437 +12
+ Misses 3180 3179 -1
- Partials 5738 5753 +15
Continue to review full report at Codecov.
|
paulgessinger
approved these changes
Nov 2, 2021
kodiakhq bot
pushed a commit
that referenced
this pull request
Mar 18, 2022
This PR adds the `ITkSeedingExample.cpp` to run the ITk seeding. It shows how to configure the non-equidistant binning in z (#1005), the seed confirmation cuts (#1084), the radial range for middle SP cut (#1084) and the vector containing the map of z neighbours (#1052 and #1038). It contains all the parameters to run the seeding for ITk **pixel** space points (I intend to extend this to ITk strip SPs soon). @noemina @paulgessinger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
Gridinterface ofneighborHoodIndiceswith differing lower and upper neighbors. This now allows to specify the number of neighbors desired per axis, as opposed to having one number of neighbors for all axes. It also inverts the way neighbors are interpreted:BREAKING CHANGE: The
Gridinterface changes: f you want 1 neighbor on the left and two on the right, you now have to write{-1,2}instead of{1,2}as before. This is necessary as this also allows to give "negative" neighbors, i.e. not starting from the current bin, but e.g. only 2 bins left of the current bin:{-2,-1}.