feat: MultiTrajectory chi2 handling #1057
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
MultiTrajectory
always initialize thechi2
value to0
. In addition, I updatedMultiTrajectoryHelpers::trajectoryState
to only add track statechi2
to the overallchi2sum
for measurement track states.Outlier track states'
chi2
is still recorded in the separateoutlierChi2
.I think this makes sense since the outlier is not actually used in the fit, and the track state can only contain the predicted
chi2
rather than the filteredchi2
that the measurement states have.Does this make sense @XiaocongAi?