Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MultiTrajectory chi2 handling #1057

Merged
merged 2 commits into from
Oct 29, 2021

Conversation

paulgessinger
Copy link
Member

This PR makes MultiTrajectory always initialize the chi2 value to 0. In addition, I updated MultiTrajectoryHelpers::trajectoryState to only add track state chi2 to the overall chi2sum for measurement track states.
Outlier track states' chi2 is still recorded in the separate outlierChi2.
I think this makes sense since the outlier is not actually used in the fit, and the track state can only contain the predicted chi2 rather than the filtered chi2 that the measurement states have.

Does this make sense @XiaocongAi?

CKF: set non source link TS chi2 to 0 explicitly
@paulgessinger
Copy link
Member Author

This will change the output root file hashes, which I'll update once the CI concludes.

@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #1057 (9f33d21) into main (af862bc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1057   +/-   ##
=======================================
  Coverage   48.57%   48.57%           
=======================================
  Files         338      338           
  Lines       17343    17343           
  Branches     8200     8200           
=======================================
  Hits         8425     8425           
  Misses       3180     3180           
  Partials     5738     5738           
Impacted Files Coverage Δ
Core/include/Acts/EventData/MultiTrajectory.hpp 70.53% <ø> (ø)
.../include/Acts/EventData/MultiTrajectoryHelpers.hpp 50.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af862bc...9f33d21. Read the comment docs.

Copy link
Contributor

@Corentin-Allaire Corentin-Allaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me this make sense but we should wait probably for @XiaocongAi comments just to be sure.

@paulgessinger paulgessinger merged commit 8ce4d31 into acts-project:main Oct 29, 2021
@paulgessinger paulgessinger deleted the fix/mtj-chi2-handling branch October 29, 2021 19:46
@paulgessinger paulgessinger modified the milestones: next, v15.0.0 Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants