Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add a deprecation warning to all example executables #1082

Merged
merged 2 commits into from
Nov 30, 2021

Conversation

paulgessinger
Copy link
Member

If we eventually want to remove the example executables, we should show a deprecation warning when they are used.

@paulgessinger paulgessinger added this to the next milestone Nov 23, 2021
@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #1082 (b5f6a40) into main (0a2239f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1082   +/-   ##
=======================================
  Coverage   48.61%   48.61%           
=======================================
  Files         341      341           
  Lines       17499    17499           
  Branches     8261     8261           
=======================================
  Hits         8508     8508           
  Misses       3218     3218           
  Partials     5773     5773           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a2239f...b5f6a40. Read the comment docs.

@asalzburger
Copy link
Contributor

Yes, except for the AnalysisApps executables.

@paulgessinger
Copy link
Member Author

@asalzburger does that use ActsExamples::Options::makeDefaultOptions?

@asalzburger asalzburger enabled auto-merge (squash) November 30, 2021 16:33
@kodiakhq kodiakhq bot merged commit 85e8d37 into acts-project:main Nov 30, 2021
@paulgessinger paulgessinger modified the milestones: next, v15.1.0 Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants