Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: documentation for AnalysisApps #1086

Merged
merged 3 commits into from
Nov 29, 2021

Conversation

asalzburger
Copy link
Contributor

This adds documentation for the ActsAnalysis* applications, with example plots.

It also fixes a crash if run with -h option only, and fixes a wrong default tree name.

@asalzburger asalzburger added this to the next milestone Nov 26, 2021
@asalzburger asalzburger added the Improvement Changes to an existing feature label Nov 26, 2021
@asalzburger asalzburger changed the title doc: documentation for AnalysisApps feat: documentation for AnalysisApps Nov 26, 2021
@asalzburger
Copy link
Contributor Author

Hey @Corentin-Allaire - as discussed, here is the documentation update for the AnalysisApps.

@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #1086 (526bc73) into main (a7aa600) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1086   +/-   ##
=======================================
  Coverage   48.64%   48.64%           
=======================================
  Files         341      341           
  Lines       17489    17489           
  Branches     8256     8256           
=======================================
  Hits         8508     8508           
  Misses       3208     3208           
  Partials     5773     5773           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7aa600...526bc73. Read the comment docs.

Copy link
Contributor

@Corentin-Allaire Corentin-Allaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great ! There is just one sentence that I find a bit weird.

docs/examples/analysis_apps.rst Outdated Show resolved Hide resolved
@asalzburger asalzburger merged commit b693476 into acts-project:main Nov 29, 2021
@paulgessinger paulgessinger modified the milestones: next, v15.1.0 Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Changes to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants