Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing include in EigenStepper.hpp #1117

Merged

Conversation

paulgessinger
Copy link
Member

Self explanatory. This doesn't give a compilation error because we never compile the Eigen Stepper header on it's own.

@paulgessinger paulgessinger added this to the next milestone Dec 14, 2021
Copy link
Contributor

@Corentin-Allaire Corentin-Allaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding this !

@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #1117 (dabc904) into main (67afb40) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1117   +/-   ##
=======================================
  Coverage   48.56%   48.56%           
=======================================
  Files         341      341           
  Lines       17493    17493           
  Branches     8245     8245           
=======================================
  Hits         8495     8495           
  Misses       3237     3237           
  Partials     5761     5761           
Impacted Files Coverage Δ
Core/include/Acts/Propagator/EigenStepper.hpp 67.56% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67afb40...dabc904. Read the comment docs.

@kodiakhq kodiakhq bot merged commit d5840d1 into acts-project:main Dec 14, 2021
@paulgessinger paulgessinger modified the milestones: next, v16.0.0 Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants