-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make binning explicitly configurable in TGeo example #1126
Conversation
Some more testing is needed, but the trackstate plot looks better: |
Examples/Detectors/TGeoDetector/include/ActsExamples/TGeoDetector/TGeoDetector.hpp
Show resolved
Hide resolved
Btw, I think root can actually evaluate |
|
Codecov Report
@@ Coverage Diff @@
## main #1126 +/- ##
=======================================
Coverage 48.18% 48.18%
=======================================
Files 341 341
Lines 17644 17644
Branches 8323 8323
=======================================
Hits 8502 8502
Misses 3367 3367
Partials 5775 5775 Continue to review full report at Codecov.
|
Thanks for this update. I tested it with your ITk JSON in acts-detector-examples!11 and it works perfectly for me too - just as you show above. With the Python bindings, we should also update the
I guess the change needed is to add |
That's a good point. Yes, I think it needs both configurations added. The binning option is at least already registered in this PR, I will add the configuration |
This PR makes the surface binning in the TGeo Detector example explicitly configurable. In the json configuration a vector of bins for
loc0
andloc1
is added for the negative, central and positive detector regions respectively. The binning must be set per layer, meaning that the number of layers must be known when configuring the detector building. Alternatively, a single binning entry of0
can be used to trigger autobinning.Also adds itk module splitter options to python bindings and enables tgeo json config dump from existing json config.