Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Scale backward filtering covariance #1147

Merged

Conversation

Corentin-Allaire
Copy link
Contributor

Add an option to scale up the covariance matrix before performing the backward filtering for the Kalman fitter. Scaling this covariance might be necessary to obtain a reasonable smoothed covariance at the end of the backward filtering and shouldn't affect the performance.

@Corentin-Allaire Corentin-Allaire added this to the next milestone Feb 4, 2022
@Corentin-Allaire Corentin-Allaire added Component - Core Affects the Core module Impact - Minor Nuissance bug and/or affects only a single module Improvement Changes to an existing feature labels Feb 4, 2022
@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #1147 (2004d35) into main (73173e0) will increase coverage by 0.00%.
The diff coverage is 40.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1147   +/-   ##
=======================================
  Coverage   47.90%   47.90%           
=======================================
  Files         359      359           
  Lines       18492    18496    +4     
  Branches     8724     8726    +2     
=======================================
+ Hits         8859     8861    +2     
  Misses       3603     3603           
- Partials     6030     6032    +2     
Impacted Files Coverage Δ
Core/include/Acts/TrackFitting/KalmanFitter.hpp 38.23% <40.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73173e0...2004d35. Read the comment docs.

@kodiakhq kodiakhq bot merged commit b8abfb5 into acts-project:main Feb 15, 2022
@paulgessinger paulgessinger modified the milestones: next, v17.1.0 Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Component - Core Affects the Core module Impact - Minor Nuissance bug and/or affects only a single module Improvement Changes to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants