Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Python fixes #1212

Merged
merged 1 commit into from
Mar 29, 2022
Merged

ci: Python fixes #1212

merged 1 commit into from
Mar 29, 2022

Conversation

paulgessinger
Copy link
Member

Click had a breaking change in a minor version bump 8.0.4 -> 8.1.0 (see tiangolo/typer#377) and black 22.1.0 has an incompatibility with click 8.1.0 (bumping to
22.3.0 should fix this)

@paulgessinger
ci: Python fixes
722704e 
Click had a breaking change in a minor version bump `8.0.4` -> `8.1.0` (see tiangolo/typer#377) and
black `22.1.0` has an incompatibility with click `8.1.0` (bumping to
`22.3.0` should fix this)
@paulgessinger paulgessinger added this to the next milestone Mar 29, 2022
@benjaminhuth benjaminhuth self-requested a review March 29, 2022 08:19
@paulgessinger paulgessinger mentioned this pull request Mar 29, 2022
Merged
@benjaminhuth benjaminhuth removed their request for review March 29, 2022 10:55
@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #1212 (722704e) into main (94e259c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1212   +/-   ##
=======================================
  Coverage   47.75%   47.75%           
=======================================
  Files         360      360           
  Lines       18616    18616           
  Branches     8774     8774           
=======================================
  Hits         8890     8890           
  Misses       3674     3674           
  Partials     6052     6052

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@paulgessinger paulgessinger mentioned this pull request Mar 29, 2022
Merged
@stephenswat stephenswat added Bug Something isn't working Impact - Critical Critical bug that blocks further developments labels Mar 29, 2022
@kodiakhq kodiakhq bot merged commit f9a8b4d into acts-project:main Mar 29, 2022
@paulgessinger paulgessinger deleted the ci/python-fixes branch March 29, 2022 12:29
@tiangolo
Copy link

I just released Typer 0.4.1 that should handle this. 🚀 🤓

@paulgessinger paulgessinger modified the milestones: next, v18.0.0 Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertlangenberg robertlangenberg robertlangenberg approved these changes

Assignees
No one assigned
Labels
automerge Bug Something isn't working Impact - Critical Critical bug that blocks further developments
Projects
None yet
Milestone
v18.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@paulgessinger @tiangolo @robertlangenberg @stephenswat