feat: change name of numPhiNeighbors in the grid #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuisFelipeCoelho
added
Component - Core
Codecov Report
@@ Coverage Diff @@
## main #1220 +/- ##
=======================================
Coverage 47.86% 47.86%
=======================================
Files 372 372
Lines 19443 19443
Branches 9151 9151
=======================================
Hits 9306 9306
Misses 3806 3806
Partials 6331 6331
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
robertlangenberg
suggested changes
Mar 31, 2022
robertlangenberg
approved these changes
Apr 5, 2022
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Apr 11, 2022
* change numPhiNeighbors in grid creation step * set default value * addressing comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @robertlangenberg and @noemina have addressed in PR #1167 and issue #1172,
numPhiNeighborsfor Grid and BinFinder don't mean the same. ThenumPhiNeighborsfor the Grid is the number of phiBin neighbors that should cover the full deflection of a minimum pT particle, whilenumPhiNeighborsin the BinFinder is the number of phi bin neighbors (including the current one) that are used to search for SPs.This PR renames
numPhiNeighborsfor the Grid tophiBinDeflectionCoverageand allows for even numbers of phiBins.