-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Kalman Filter with ATLAS Stepper #1223
fix: Kalman Filter with ATLAS Stepper #1223
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1223 +/- ##
==========================================
- Coverage 47.89% 47.64% -0.26%
==========================================
Files 375 375
Lines 19588 19624 +36
Branches 9214 9287 +73
==========================================
- Hits 9382 9350 -32
- Misses 3822 3885 +63
- Partials 6384 6389 +5
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
We may override the codecov, this is literally shifting code around, weird why this results in a negative codecov. |
It seem to be related to some internal variable not beeing tested. But I am not fully sure and don't have much expertise with codecov... |
Fix the issues related to the ATLASStepper so that it is usable with the KF :
update
instead ofresetState
it seems this is the equivalent of the jacToGlobal in the EigenSteppertransportCovarianceToBound
this would let to the covariance changing depending on how many time this method was calledAnd the
PropagationCompareAtlasEigenConstant
now also compares the covariances.