Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Kalman Filter with ATLAS Stepper #1223

Merged
merged 20 commits into from
May 18, 2022

Conversation

Corentin-Allaire
Copy link
Contributor

@Corentin-Allaire Corentin-Allaire commented Apr 4, 2022

Fix the issues related to the ATLASStepper so that it is usable with the KF :

  • The pVector is the updated in update instead of resetState it seems this is the equivalent of the jacToGlobal in the EigenStepper
  • The pVector is not updated when calling transportCovarianceToBound this would let to the covariance changing depending on how many time this method was called
  • The ATLAS Stepper now create state with the transpose of its jacobian (which correspond to the same jacobian as the Eigen Stepper one)
  • With this implementation the stepper curently doesn't work when encountering non-measurement surfaces, this is probably due to some kind of reinitialisation not being perform correctly ? This should be investigated.

And the PropagationCompareAtlasEigenConstant now also compares the covariances.

@Corentin-Allaire Corentin-Allaire added Bug Something isn't working Component - Core Affects the Core module Impact - Major Significant bug and/or affects a lot of modules 🚧 WIP Work-in-progress labels Apr 4, 2022
@Corentin-Allaire Corentin-Allaire added this to the next milestone Apr 4, 2022
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #1223 (ea587b7) into main (6c2807a) will decrease coverage by 0.25%.
The diff coverage is 58.07%.

@@            Coverage Diff             @@
##             main    #1223      +/-   ##
==========================================
- Coverage   47.89%   47.64%   -0.26%     
==========================================
  Files         375      375              
  Lines       19588    19624      +36     
  Branches     9214     9287      +73     
==========================================
- Hits         9382     9350      -32     
- Misses       3822     3885      +63     
- Partials     6384     6389       +5     
Impacted Files Coverage Δ
Core/src/TrackFitting/GainMatrixSmoother.cpp 10.41% <0.00%> (-0.70%) ⬇️
Core/include/Acts/Propagator/AtlasStepper.hpp 62.05% <58.59%> (-6.46%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Corentin-Allaire Corentin-Allaire removed the 🚧 WIP Work-in-progress label May 3, 2022
@asalzburger
Copy link
Contributor

We may override the codecov, this is literally shifting code around, weird why this results in a negative codecov.

@Corentin-Allaire
Copy link
Contributor Author

We may override the codecov, this is literally shifting code around, weird why this results in a negative codecov.

It seem to be related to some internal variable not beeing tested. But I am not fully sure and don't have much expertise with codecov...

@paulgessinger paulgessinger changed the title fix: Kf with atlas stepper fix: Kalman Filter with ATLAS Stepper May 17, 2022
@paulgessinger paulgessinger merged commit 7a4ea5a into acts-project:main May 18, 2022
@paulgessinger paulgessinger modified the milestones: next, v19.1.0 May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Component - Core Affects the Core module Impact - Major Significant bug and/or affects a lot of modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants