-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: GSF python example #1232
feat: GSF python example #1232
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable overall, I've added a few comments here and there.
At the python level, there could be some cleanup. I'm also wondering if at this point we should rename truth_tracking.py
to make it obvious it runs the KF.
Aside from that: do you think you could look into running the GSF example from a pytest test, so we run it in the CI and do basic checks on the output? Do you have any kind of code / tooling to produce validation plots for the GSF? If so, that could potentially also be added and monitored by the CI.
Examples/Algorithms/TrackFitting/include/ActsExamples/TrackFitting/TrackFittingAlgorithm.hpp
Show resolved
Hide resolved
Regarding the physics performance monitoring: In principle the fitter returns a |
I did some renaming at this point as @paulgessinger mentioned above ( I think this is now more in line with the other examples |
Changes look good to me in principle. There's some build failures right now though. |
Codecov Report
@@ Coverage Diff @@
## main #1232 +/- ##
==========================================
- Coverage 47.71% 47.71% -0.01%
==========================================
Files 375 376 +1
Lines 19718 19722 +4
Branches 9264 9267 +3
==========================================
+ Hits 9409 9410 +1
- Misses 3920 3922 +2
- Partials 6389 6390 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Note that there are some CI issues that should be fixed by #1243. |
… execept for kf-differences
This fixes an issue in compiling using clang + libstdc++ after #1232 was merged.
This PR proposes a first version of an GSF example. The implementation of this required some bigger changes in the
TrackFittingAlgorithm
, since I wanted the TrackFittingAlgorithm to support different fitters with different options.MeasurementCalibrator
) live now inside theTrackFitterFunction
, since there may be different extensions required by different fitters. TheMeasurementCalibrator
still must live in the TrackFittingAlgorithm, since it must be constructed with the measurements, which are obviously not known when constructing theTrackFitterFunction
.Besides this there are some minor changes in the GSF (moved some config structs from
Acts::detail
toActs
, ...), but should be uncontroversial