ci: Full chain ODD monitoring follow-up #1250
Conversation
|
Would be great to get your opinion on this @andiwand. The CI will likely fail right now, because the configuration from the reference might be from a subtly different configuration. |
There was a problem hiding this comment.
cool 👍
I am just missing the setup and call of the sequencer https://gitlab.cern.ch/acts/OpenDataDetector/-/blob/main/ci/full_chain_odd.py#L69-107. is that not necessary anymore?
Codecov Report
@@ Coverage Diff @@
## main #1250 +/- ##
=======================================
Coverage 47.89% 47.89%
=======================================
Files 375 375
Lines 19588 19588
Branches 9214 9214
=======================================
Hits 9382 9382
Misses 3822 3822
Partials 6384 6384 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
It should be using the one here. Or do you mean something else? |
|
Ok, reference is updated, CI should run through now. |
|
Seems fine now, consider approving @andiwand. |
Follow-up to #1247.
This moves the extra invocation of
thirdparty/OpenDataDetector/ci/full_chain_odd.pyinto the mainCI/physmon/physmon.pyscript where we basically run this chain anyway. This saves some time since we can generate the residual and pulls output from that invocation. I also change theActsAnalysisResidualsAndPullsto be called directly from the python script, so we can reuse the temporary directory from there.This also changes
ActsAnalysisResidualsAndPullsto return UNIX-style error codes (0: ok, != 0, failure)