-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: RKN-monitoring to AtlasStepper, change type int->size_t #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1264 +/- ##
=======================================
Coverage 47.48% 47.48%
=======================================
Files 376 376
Lines 19816 19819 +3
Branches 9308 9308
=======================================
+ Hits 9410 9412 +2
- Misses 4016 4017 +1
Partials 6390 6390
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
robertlangenberg
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the PR feat: add RKN-monitoring to EigenStepper (State and root) #1256 this one adds the monitoring also to the AtlasStepper.
We also change the type of the variable
nStepTrials
fromint
tosize_t
up to the root-writer, since the EigenStepper uses this type and we want to avoid type conversions.The previous PR feat: add RKN-monitoring to EigenStepper (State and root) #1256 is missing the update of the (c)-dates. This is fixed in this PR. Therefore the following files have no changes but the date in this PR:
Core/include/Acts/Propagator/EigenStepper.hpp
Core/include/Acts/Propagator/EigenStepper.ipp
Examples/Io/Root/src/RootPropagationStepsWriter.cpp