Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: RKN-monitoring to AtlasStepper, change type int->size_t #1264

Merged
merged 11 commits into from
Jun 7, 2022

Conversation

AJPfleger
Copy link
Contributor

@AJPfleger AJPfleger commented May 23, 2022

Similar to the PR feat: add RKN-monitoring to EigenStepper (State and root) #1256 this one adds the monitoring also to the AtlasStepper.

We also change the type of the variable nStepTrials from int to size_t up to the root-writer, since the EigenStepper uses this type and we want to avoid type conversions.

The previous PR feat: add RKN-monitoring to EigenStepper (State and root) #1256 is missing the update of the (c)-dates. This is fixed in this PR. Therefore the following files have no changes but the date in this PR:

  • Core/include/Acts/Propagator/EigenStepper.hpp
  • Core/include/Acts/Propagator/EigenStepper.ipp
  • Examples/Io/Root/src/RootPropagationStepsWriter.cpp

@AJPfleger AJPfleger added the Feature Development to integrate a new feature label May 23, 2022
@AJPfleger AJPfleger added this to the next milestone May 23, 2022
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #1264 (fecf78f) into main (bd55ecb) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main    #1264   +/-   ##
=======================================
  Coverage   47.48%   47.48%           
=======================================
  Files         376      376           
  Lines       19816    19819    +3     
  Branches     9308     9308           
=======================================
+ Hits         9410     9412    +2     
- Misses       4016     4017    +1     
  Partials     6390     6390           
Impacted Files Coverage Δ
Core/include/Acts/Propagator/ConstrainedStep.hpp 74.50% <ø> (ø)
Core/include/Acts/Propagator/EigenStepper.hpp 68.42% <ø> (ø)
Core/include/Acts/Propagator/EigenStepper.ipp 50.73% <ø> (ø)
Core/include/Acts/Propagator/AtlasStepper.hpp 70.99% <66.66%> (-0.02%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@robertlangenberg robertlangenberg enabled auto-merge (squash) June 7, 2022 13:46
@robertlangenberg robertlangenberg merged commit 8a2260b into acts-project:main Jun 7, 2022
@paulgessinger paulgessinger modified the milestones: next, v19.2.0 Jun 8, 2022
@AJPfleger AJPfleger deleted the overstepping branch November 9, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Development to integrate a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants