Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bug in xyz strip coordinates transformation #1265

Merged

Conversation

LuisFelipeCoelho
Copy link
Member

This PR fixes two small bugs that I included in #1255.

@LuisFelipeCoelho LuisFelipeCoelho added Component - Core Affects the Core module Impact - Minor Nuissance bug and/or affects only a single module labels May 24, 2022
@LuisFelipeCoelho LuisFelipeCoelho added this to the next milestone May 24, 2022
@LuisFelipeCoelho LuisFelipeCoelho added the Bug Something isn't working label May 24, 2022
@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #1265 (9a5b2fb) into main (4ceddf3) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1265   +/-   ##
=======================================
  Coverage   47.49%   47.50%           
=======================================
  Files         376      376           
  Lines       19811    19810    -1     
  Branches     9305     9305           
=======================================
  Hits         9410     9410           
+ Misses       4011     4010    -1     
  Partials     6390     6390           
Impacted Files Coverage Δ
Core/include/Acts/Seeding/SeedFinderUtils.ipp 0.00% <0.00%> (ø)
Core/include/Acts/Seeding/Seedfinder.ipp 0.00% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@robertlangenberg
Copy link
Contributor

Thanks for fixing this. I think such bugs underlines the need for CI tests that run the ITk configuration

@LuisFelipeCoelho
Copy link
Member Author

Thanks for fixing this. I think such bugs underlines the need for CI tests that run the ITk configuration

I will work on that

@robertlangenberg robertlangenberg enabled auto-merge (squash) May 25, 2022 09:12
@robertlangenberg robertlangenberg merged commit a7ee09d into acts-project:main May 25, 2022
@paulgessinger paulgessinger modified the milestones: next, v19.2.0 Jun 8, 2022
@LuisFelipeCoelho LuisFelipeCoelho deleted the Itk-xyzCoordinate-bug branch July 25, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Component - Core Affects the Core module Impact - Minor Nuissance bug and/or affects only a single module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants